rahul37wallst-sudo opened a new pull request, #21669:
URL: https://github.com/apache/echarts/pull/21669

   ```md
   <!-- Please fill in the following information to help us review your PR more 
efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Reset the active toolbox dataZoom selection cursor when toolbox restore is 
clicked.
   
   
   
   ### Fixed issues
   
   - #21644: Restore feature does not properly reset the toolbox dataZoom 
cursor state.
   
   
   ## Details
   
   ### Before: What was the problem?
   
   After activating toolbox dataZoom selection and then clicking toolbox 
restore, the chart data range was restored, but the dataZoom selection 
cursor/brush state could remain active.
   
   This left the chart in the zoom selection interaction mode after restore.
   
   
   
   ### After: How does it behave after the fixing?
   
   Toolbox restore now releases the global cursor before dispatching the 
restore action.
   
   This disables the active dataZoom select brush state, restores the toolbox 
zoom icon to normal, and prevents the stale zoom selection cursor from 
remaining active after restore.
   
   A unit test was added for the toolbox dataZoom restore path.
   
   
   
   ## Document Info
   
   One of the following should be checked.
   
   - [x] This PR doesn't relate to document changes
   - [ ] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   
   
   ## Misc
   
   ### Security Checking
   
   - [ ] This PR uses security-sensitive Web APIs.
   
   <!-- PLEASE CHECK IT AGAINST: 
<https://github.com/apache/echarts/wiki/Security-Checklist-for-Code-Contributors>
 -->
   
   ### ZRender Changes
   
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   `test/ut/spec/component/toolbox/DataZoom.test.ts`
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   
   Validation run:
   
   - `npx jest --config test/ut/jest.config.cjs --coverage=false 
test/ut/spec/component/toolbox/DataZoom.test.ts --runInBand`
   - `npx eslint src/component/toolbox/feature/Restore.ts 
test/ut/spec/component/toolbox/DataZoom.test.ts`
   - `git diff --check`
   - `npm run checktype`
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to