AstrorEnales opened a new pull request, #21677: URL: https://github.com/apache/echarts/pull/21677
<!-- Please fill in the following information to help us review your PR more efficiently. --> ## Brief Information This pull request is in the type of: - [X] bug fixing - [ ] new feature - [ ] others ### What does this PR do? This PR improves the edge adjustment in graph series for different symbol shapes. Previously, the endpoints of edges were positioned on a circle around the actual node symbol. This resulted in edge endpoints sometimes being hidden behind the symbol and sometimes too far away. The new logic uses exact formulas for some symbol types and intersections for more complex paths. For data image symbols the rectangular outline of the symbol is used. ### Fixed issues - #10563: Issue of the end points of edges in Graph chart ## Details ### Before: What was the problem? Endpoints of edges were positioned on a circle around the actual node symbol. This resulted in edge endpoints sometimes being hidden behind the symbol and sometimes too far away. <img width="2340" height="1813" alt="before" src="https://github.com/user-attachments/assets/7bebdbfd-32c2-49d8-bda1-ac75d06f1883"; /> ### After: How does it behave after the fixing? The new logic uses exact formulas for some symbol types and intersections for more complex paths. For data image symbols the rectangular outline of the symbol is used. <img width="2340" height="1813" alt="after" src="https://github.com/user-attachments/assets/012eebb2-0920-47ca-a023-c02938599201"; /> ## Document Info One of the following should be checked. - [X] This PR doesn't relate to document changes - [ ] The document should be updated later - [ ] The document changes have been made in apache/echarts-doc#xxx ## Misc ### Related test cases or examples to use the new APIs - test/graph-edge-shape.html - test/ut/spec/series/graph/nodeShapeHelper.test.ts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
