aloktomarr commented on issue #19060: URL: https://github.com/apache/echarts/issues/19060#issuecomment-5004307567
I would love to fix this issue. Root cause: [HeatmapView.render]() reads [seriesModel.coordinateSystem.type]() without checking that the coordinate system was resolved. When a heatmap references a coordinate system whose component is missing (e.g. [coordinateSystem: 'calendar']()/`'bmap'` not registered), [coordinateSystem]() is `undefined`, so [coordSys.type]() throws [Cannot read properties of undefined (reading 'type')]() and the whole render aborts. Notably, [incrementalRender]() already guards this with [if (coordSys)](); [render]() was missing the same check. Fix: add the same `if (!coordSys) return;` guard in [render]() so a misconfigured/unresolved coordinate system is skipped gracefully (ECharts still logs its usual "coordinate system cannot be found" warning) instead of crashing. Added a regression test. PR incoming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
