vicuts opened a new pull request, #21785:
URL: https://github.com/apache/echarts/pull/21785
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Fixes a typo and two incorrect series type names in the Romanian locale
(`src/i18n/langRO.ts`).
### Fixed issues
None.
## Details
### Before: What was the problem?
Three values in `langRO.ts` were wrong:
| Key | Before | After |
| --- | --- | --- |
| `aria.general.withTitle` | `Aceasta este o diagrmă despre "{title}"` |
`Aceasta este o diagramă despre "{title}"` |
| `series.typeNames.gauge` | `Calibru` | `Indicator` |
| `series.typeNames.boxplot` | `Diagramă boxbare` | `Diagramă boxplot` |
- `diagrmă` is a typo of `diagramă` (chart). It shows up in the aria label
of every chart that has a title, so screen reader users hear a misspelled word.
- `Calibru` means caliber, or a gauge block used to check dimensions. It
does not describe a dial chart.
- `boxbare` is not a Romanian word.
### After: How does it behave after the fixing?
- The typo is fixed.
- `gauge` becomes `Indicator`, the usual Romanian word for a measuring
instrument with a scale and a needle (as in "indicator de presiune" or
"indicator de nivel"), which is what the gauge series draws. The Czech
(`Indikátor`), Latvian (`Rādītājs`) and Turkish (`Gösterge`) locales use the
same idea. I did not use `Cadran` (dial) because in a chart context it also
means a quadrant of the coordinate plane.
- `boxplot` becomes `Diagramă boxplot`, the term used by the Romanian
Wikipedia article on the box plot. It also matches the English `Boxplot`.
Only `src/i18n/langRO.ts` is changed. The generated files in `i18n/` are
left for the release build, as the PR guide asks.
## Document Info
One of the following should be checked.
- [x] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### Security Checking
- [ ] This PR uses security-sensitive Web APIs.
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
`npx eslint src/i18n/langRO.ts` and `npx tsc --noEmit -p tsconfig.json` both
pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
