This is an automated email from the ASF dual-hosted git repository.
mikexue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/eventmesh.git
The following commit(s) were added to refs/heads/master by this push:
new 4b994b030 [ISSUE #4021] Replace LinkedList by ArrayList (#4233)
4b994b030 is described below
commit 4b994b0308a74de2290103b2ecf95dcd85d41f11
Author: Vincent Low <[email protected]>
AuthorDate: Thu Jul 20 14:58:39 2023 +0700
[ISSUE #4021] Replace LinkedList by ArrayList (#4233)
* replace LinkedList by ArrayList
* update import order
---
.../java/org/apache/eventmesh/common/protocol/tcp/Subscription.java | 4 ++--
.../java/org/apache/eventmesh/runtime/boot/EventMeshGrpcServer.java | 4 ++--
.../runtime/core/protocol/grpc/consumer/ConsumerManager.java | 3 +--
.../eventmesh/client/tcp/impl/cloudevent/CloudEventTCPSubClient.java | 4 ++--
.../tcp/impl/eventmeshmessage/EventMeshMessageTCPSubClient.java | 4 ++--
5 files changed, 9 insertions(+), 10 deletions(-)
diff --git
a/eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/tcp/Subscription.java
b/eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/tcp/Subscription.java
index 943988f32..f1a6dbcdd 100644
---
a/eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/tcp/Subscription.java
+++
b/eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/tcp/Subscription.java
@@ -19,12 +19,12 @@ package org.apache.eventmesh.common.protocol.tcp;
import org.apache.eventmesh.common.protocol.SubscriptionItem;
-import java.util.LinkedList;
+import java.util.ArrayList;
import java.util.List;
public class Subscription {
- private List<SubscriptionItem> topicList = new LinkedList<>();
+ private List<SubscriptionItem> topicList = new ArrayList<>();
public Subscription() {
}
diff --git
a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshGrpcServer.java
b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshGrpcServer.java
index 546119214..4a5cdb2ae 100644
---
a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshGrpcServer.java
+++
b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshGrpcServer.java
@@ -41,8 +41,8 @@ import org.apache.commons.lang3.RandomUtils;
import org.apache.http.impl.client.CloseableHttpClient;
import org.apache.http.impl.client.HttpClients;
+import java.util.ArrayList;
import java.util.Iterator;
-import java.util.LinkedList;
import java.util.List;
import java.util.Optional;
import java.util.concurrent.BlockingQueue;
@@ -276,7 +276,7 @@ public class EventMeshGrpcServer {
}
private void initHttpClientPool() {
- httpClientPool = new LinkedList<>();
+ httpClientPool = new ArrayList<>();
int clientPool = RandomUtils.nextInt(MIN_LIMIT, MAX_LIMIT);
for (int i = 0; i < clientPool; i++) {
CloseableHttpClient client = HttpClients.createDefault();
diff --git
a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/consumer/ConsumerManager.java
b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/consumer/ConsumerManager.java
index 1260a6bc6..cbe61e22d 100644
---
a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/consumer/ConsumerManager.java
+++
b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/consumer/ConsumerManager.java
@@ -32,7 +32,6 @@ import java.util.ArrayList;
import java.util.Date;
import java.util.HashSet;
import java.util.Iterator;
-import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.Set;
@@ -210,7 +209,7 @@ public class ConsumerManager {
log.debug("grpc client info check");
}
- final List<ConsumerGroupClient> clientList = new
LinkedList<>();
+ final List<ConsumerGroupClient> clientList = new ArrayList<>();
clientTable.values().forEach(clients -> {
clientList.addAll(clients);
});
diff --git
a/eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/cloudevent/CloudEventTCPSubClient.java
b/eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/cloudevent/CloudEventTCPSubClient.java
index dbebc6dcc..373c12e9b 100644
---
a/eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/cloudevent/CloudEventTCPSubClient.java
+++
b/eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/cloudevent/CloudEventTCPSubClient.java
@@ -35,8 +35,8 @@ import org.apache.eventmesh.common.protocol.tcp.Package;
import org.apache.commons.collections4.CollectionUtils;
import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
import java.util.Collections;
-import java.util.LinkedList;
import java.util.List;
import java.util.concurrent.ConcurrentHashMap;
@@ -56,7 +56,7 @@ import lombok.extern.slf4j.Slf4j;
@Slf4j
class CloudEventTCPSubClient extends TcpClient implements
EventMeshTCPSubClient<CloudEvent> {
- private final List<SubscriptionItem> subscriptionItems =
Collections.synchronizedList(new LinkedList<>());
+ private final List<SubscriptionItem> subscriptionItems =
Collections.synchronizedList(new ArrayList<>());
private ReceiveMsgHook<CloudEvent> callback;
public CloudEventTCPSubClient(EventMeshTCPClientConfig
eventMeshTcpClientConfig) {
diff --git
a/eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/eventmeshmessage/EventMeshMessageTCPSubClient.java
b/eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/eventmeshmessage/EventMeshMessageTCPSubClient.java
index dc159e1e1..cb589eb49 100644
---
a/eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/eventmeshmessage/EventMeshMessageTCPSubClient.java
+++
b/eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/tcp/impl/eventmeshmessage/EventMeshMessageTCPSubClient.java
@@ -36,8 +36,8 @@ import org.apache.eventmesh.common.utils.JsonUtils;
import org.apache.commons.collections4.CollectionUtils;
+import java.util.ArrayList;
import java.util.Collections;
-import java.util.LinkedList;
import java.util.List;
import java.util.concurrent.ConcurrentHashMap;
@@ -48,7 +48,7 @@ import lombok.extern.slf4j.Slf4j;
@Slf4j
class EventMeshMessageTCPSubClient extends TcpClient implements
EventMeshTCPSubClient<EventMeshMessage> {
- private final List<SubscriptionItem> subscriptionItems =
Collections.synchronizedList(new LinkedList<>());
+ private final List<SubscriptionItem> subscriptionItems =
Collections.synchronizedList(new ArrayList<>());
private ReceiveMsgHook<EventMeshMessage> callback;
public EventMeshMessageTCPSubClient(EventMeshTCPClientConfig
eventMeshTcpClientConfig) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
