This is an automated email from the ASF dual-hosted git repository.
mikexue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/eventmesh.git
The following commit(s) were added to refs/heads/master by this push:
new 4119ada63 [ISSUE #4202] Do some code optimization.[util] (#4230)
4119ada63 is described below
commit 4119ada632d58c2fb56e6064c2b5249ce83e2045
Author: Fabian Bao <[email protected]>
AuthorDate: Thu Jul 20 16:00:54 2023 +0800
[ISSUE #4202] Do some code optimization.[util] (#4230)
* Do some code optimization.[util]
* Do some code optimization.[util]
---
.../org/apache/eventmesh/runtime/util/HttpResponseUtils.java | 12 +++++++-----
.../org/apache/eventmesh/runtime/util/ValueComparator.java | 2 ++
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git
a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/HttpResponseUtils.java
b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/HttpResponseUtils.java
index 95cf01019..0b3812f8a 100644
---
a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/HttpResponseUtils.java
+++
b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/HttpResponseUtils.java
@@ -29,6 +29,7 @@ import io.netty.handler.codec.http.HttpHeaders;
import io.netty.handler.codec.http.HttpResponse;
import io.netty.handler.codec.http.HttpResponseStatus;
import io.netty.handler.codec.http.HttpVersion;
+import io.netty.util.AsciiString;
public class HttpResponseUtils {
@@ -52,16 +53,17 @@ public class HttpResponseUtils {
}
public static HttpResponse setResponseJsonBody(String body,
ChannelHandlerContext ctx) {
- HttpHeaders responseHeaders = new DefaultHttpHeaders();
- responseHeaders.add(HttpHeaderNames.CONTENT_TYPE,
HttpHeaderValues.APPLICATION_JSON);
- return new DefaultFullHttpResponse(HttpVersion.HTTP_1_1,
HttpResponseStatus.OK, crateByteBuf(ctx, body),
- responseHeaders, responseHeaders);
+ return getHttpResponse(body, ctx, HttpHeaderValues.APPLICATION_JSON);
}
public static HttpResponse setResponseTextBody(String body,
ChannelHandlerContext ctx) {
+ return getHttpResponse(body, ctx, HttpHeaderValues.TEXT_HTML);
+ }
+
+ public static HttpResponse getHttpResponse(String body,
ChannelHandlerContext ctx, AsciiString headerValue) {
HttpHeaders responseHeaders = new DefaultHttpHeaders();
- responseHeaders.add(HttpHeaderNames.CONTENT_TYPE,
HttpHeaderValues.TEXT_HTML);
+ responseHeaders.add(HttpHeaderNames.CONTENT_TYPE, headerValue);
return new DefaultFullHttpResponse(HttpVersion.HTTP_1_1,
HttpResponseStatus.OK, crateByteBuf(ctx, body),
responseHeaders, responseHeaders);
}
diff --git
a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/ValueComparator.java
b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/ValueComparator.java
index a84dfbd4b..8622e6503 100644
---
a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/ValueComparator.java
+++
b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/ValueComparator.java
@@ -23,6 +23,8 @@ import java.util.Map;
public class ValueComparator implements Comparator<Map.Entry<String,
Integer>>, Serializable {
+ private static final long serialVersionUID = -8734777387846774249L;
+
@Override
public int compare(Map.Entry<String, Integer> x, Map.Entry<String,
Integer> y) {
if (x.getValue().intValue() != y.getValue().intValue()) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
