delei commented on issue #678: URL: https://github.com/apache/fesod/issues/678#issuecomment-3567468889
> Hi [@delei](https://github.com/delei), you're absolutely right about the security issue with `pull_request` not being able to access secrets from forks. The solution is to change `pull_request` to `pull_request_target` in `preview-docs.yml`. This will run the workflow in the base repository's context so it can access secrets. Since we're only building static documentation and deploying to Netlify, it's safe to use `pull_request_target` here. Changes that need to be made: > > name: Preview Documentation > > on: > - pull_request: > + pull_request_target: > paths: > - 'website/**' > I can submit a PR for this change if you'd like. After it's merged, we can continue to test the preview on PR [#707](https://github.com/apache/fesod/pull/707) to verify it works correctly. Apologies for any confusion with the previous PRs. -1 , The `pull_request_target` poses a security risk and we should avoid using it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
