ongdisheng commented on issue #678:
URL: https://github.com/apache/fesod/issues/678#issuecomment-3568128539
Hi @alaahong, Thanks for sharing the configuration! Let me clarify the
different approaches:
1. The empty Netlify settings approach relies entirely on GitHub Actions CI
to build and deploy. However, it's not working for PR 709 because:
- The current `preview-docs.yml` workflow uses `pull_request` trigger
- For fork PRs, GitHub doesn't provide secrets for security reasons
- So the workflow can't access `NETLIFY_AUTH_TOKEN` and
`NETLIFY_SITE_ID` to deploy
2. Netlify build settings approach (what you tried):
> Base directory: website
> Build command: pnpm build
> Publish directory: build
This approach lets Netlify handle the build directly similar to the Selenium
repo you shared with me previously. However, it requires a `pnpm-lock.yaml`
file in the `website/` folder, which we don't have in our repository. That's
why the builds are failing.
My proposed solution: The secure two-workflow pattern uses the
`workflow_run` trigger, which only works when the workflow file exists on the
main branch. So it seems like we need to merge it to main first before it can
be tested with PRs. Let me know what you think or if you have other suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
