myrle-krantz commented on issue #3: Docker infrastructure for Eureka and ActiveMQ URL: https://github.com/apache/fineract-cn-demo-server/pull/3#issuecomment-380554598 Hey Viswa, as I said, your change breaks the demo-server for me. Until you've remedied that, I can't merge it. As to your points about JUnit and testing: the demo-server evolved from an integration test which I used to debug the provisioning code and the interaction between identity and provisioner. I copied that code into the demo-server originally so that a UI developer could deploy the system locally to code against it. He needed it to test fims against a running backend. It is *not* intended as a production-ready deployment. It took me weeks to get the interplay between the various pieces right, and I never would have achieved it without the demo-server. I provided it to the project since the provisioning code is non-trivial, and most people trying to use it will need a starting point. This is a microservices architecture. The whole framework was never intended for a single system deployment, so of course the demo-server isn't something anyone would ever use in this form in production. Further, most companies will have very different needs, and will want to change various aspects of the provisioning including, but not limited to which services are provisioned, what roles and users are created, which users originate the events produced by rhythm, and what tenants are created. Your understanding is correct: "You'll have to pull fineract-cn-test because that's where I added the "RunExternalResourceConditionally" test rule." Greets, Myrle
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
