myrle-krantz commented on issue #3: Docker infrastructure for Eureka and ActiveMQ URL: https://github.com/apache/fineract-cn-demo-server/pull/3#issuecomment-384326074 Hey Viswa: Your PR has conflicts, probably resulting from the package rename from mifos to apache. I didn't want to put that rename off any longer, because I was afraid I would end up causing conflicts in more PRs if I continued to delay. My apologies for the inconvenience. But even with those conflicts resolved, I still can't merge your PR because it breaks the demo-server the way I use it. I believe tests with docker infra can be an interesting approach, but I don't want to lose the one click startup. If you still want to move this forward, you'll need to figure out which one of your changes breaks the embedded startup. I repeat: my demo-server works just fine without your changes. With your changes it does not work. The important diff seems to be your addition of the application.yml file. If I remove that, my demo-server works.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
