vorburger commented on a change in pull request #593: Create one-touch deploy
with docker
URL: https://github.com/apache/fineract/pull/593#discussion_r297652868
##########
File path: fineract-provider/build.gradle
##########
@@ -125,6 +125,10 @@ rat {
'**/native/**',
'**/wrapper/**',
'**/build/**',
+ // docker
+ '**/Dockerfile/**',
+ '**/docker-compose.yml/**',
+ '**/initdb/**',
Review comment:
it just occured to me that it would probably be better to add the ASF
required license headers instead of suprressing this here like this... at least
for YAML files (like docker-compose.yml) it's possible, see the
https://github.com/apache/fineract/blob/develop/.travis.yml, and for
01-databases.sql it's possible as well, see e.g. the
https://github.com/apache/fineract/blob/develop/fineract-db/mifospltaform-tenants-first-time-install.sql
et all. Not 100% sure re. the Dockerfile, but just try adding a license header
to it, and see if rat (the license check tool, which you can run locally via
`./gradlew licenseMain licenseTest licenseIntegrationTest`) is happy, without
having to add these ignores?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
