vorburger commented on a change in pull request #593: Create one-touch deploy with docker URL: https://github.com/apache/fineract/pull/593#discussion_r297651101
########## File path: Dockerfile ########## @@ -0,0 +1,20 @@ +FROM bitnami/tomcat:7.0.94 as fineract + +USER root +RUN apt-get update -qq && apt-get install -y git openjdk-8-jdk wget +ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64/jre + +RUN mkdir fineract +COPY . fineract + +WORKDIR fineract +RUN sed -i 's/localhost/fineractmysql/' ./fineract-provider/build.gradle Review comment: Right, but you (in this Dockerfile) don't even actually run those Flyway tasks (which are hopefully going to go away some time) - you, correctly only `RUN ./gradlew clean war` - and that doesn't actually require _mysql to be running on localhost_ agreed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
