vorburger commented on a change in pull request #614: Stop creating unnecessary
overdue charge when amount is 0.
URL: https://github.com/apache/fineract/pull/614#discussion_r301426625
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java
##########
@@ -2359,6 +2359,9 @@ public void applyOverdueChargesForLoan(final Long
loanId, Collection<OverdueLoan
null, null, null, loanId, null, null, null,
null,null,null);
LoanOverdueDTO overdueDTO =
applyChargeToOverdueLoanInstallment(loanId, overdueInstallment.getChargeId(),
overdueInstallment.getPeriodNumber(), command, loan,
existingTransactionIds, existingReversedTransactionIds);
+ if(overdueDTO == null){
Review comment:
is there really a realistic case when `overdueDTO` can be `null` ? If not,
then this could hide future bugs, and it would be better to remove this and let
it explode with a NullPointerException to find such bugs, instead of silently
ignoring a condition which shold never happen. If it can happen, then it's fine
- but I don't see how.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
