vorburger commented on a change in pull request #614: Stop creating unnecessary
overdue charge when amount is 0.
URL: https://github.com/apache/fineract/pull/614#discussion_r301673081
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java
##########
@@ -2359,6 +2359,9 @@ public void applyOverdueChargesForLoan(final Long
loanId, Collection<OverdueLoan
null, null, null, loanId, null, null, null,
null,null,null);
LoanOverdueDTO overdueDTO =
applyChargeToOverdueLoanInstallment(loanId, overdueInstallment.getChargeId(),
overdueInstallment.getPeriodNumber(), command, loan,
existingTransactionIds, existingReversedTransactionIds);
+ if(overdueDTO == null){
Review comment:
> `applyChargeToOverdueLoanInstallment` won't ever return a null
`overdueDTO` as the return itself is a constructor call.
OK but then you agree that this null check is unnecessary? If as you say
it's impossible for `overdueDTO` to ever be null (because
`applyChargeToOverdueLoanInstallment` ends with a `return new LoanOverdueDTO`)
then why add this nul lcheck as part of this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
