vorburger commented on a change in pull request #662: FINERACT-797: Use Spring Boot BOM to avoid maintaining version numbers in dependencies.gradle URL: https://github.com/apache/fineract/pull/662#discussion_r352314816
########## File path: fineract-provider/build.gradle ########## @@ -21,11 +21,11 @@ Run as: gradle clean tomcatrunwar ''' -project.ext.springBootVersion = '2.1.9.RELEASE' -project.ext.springVersion = '5.1.10.RELEASE' -project.ext.springOauthVersion = '2.3.6.RELEASE' -project.ext.jerseyVersion = '1.17' -project.ext.springDataJpaVersion = '2.2.0.RELEASE' // also change spring-boot-gradle-plugin version below +// project.ext.springBootVersion = '2.1.9.RELEASE' +// project.ext.springVersion = '5.1.10.RELEASE' +// project.ext.springOauthVersion = '2.3.6.RELEASE' +// project.ext.jerseyVersion = '1.17' Review comment: Given that this Jersey version is repeated twice, how about keeping this single declaration, and using it in the 2 places below? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
