vorburger commented on a change in pull request #662: FINERACT-797: Use Spring
Boot BOM to avoid maintaining version numbers in dependencies.gradle
URL: https://github.com/apache/fineract/pull/662#discussion_r352435918
##########
File path: fineract-provider/build.gradle
##########
@@ -59,9 +61,83 @@ apply plugin: 'com.bmuschko.tomcat'
apply plugin: 'project-report'
apply plugin: 'java'
apply plugin: 'openjpa'
+
// apply plugin: 'pmd'
// apply plugin: 'findbugs'
+dependencyManagement {
+ imports {
+ mavenBom 'org.springframework:spring-framework-bom:5.1.10.RELEASE'
+ }
+ dependencies {
Review comment:
> but the version conflicts were too big breaking builds
@xurror OK, then let's do that (you or someone else later) separately; I've
just created new https://issues.apache.org/jira/browse/FINERACT-805 so that we
don't forget to follow-up on that... (It's surely best to raise small PRs for
each one of these, instead of one big one for everything together.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services