thesmallstar opened a new pull request #723: FINERACT-808 FIXES: Some Action names do not filter audit trails URL: https://github.com/apache/fineract/pull/723 ## Description please refer: https://issues.apache.org/jira/browse/FINERACT-808 The filter did not work as backend would treat "UPDATE" and similar strings as SQL injection. Since, it is in where clause this *probably* need not be verified(I have researched, but would still require a confirmation from mentors). To solve this all the functions where the keywords such as update where verified are removed particularly for this statement. -thankyou ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API. - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed. - [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes. - [ ] Integration tests have been created/updated for verifying the changes made. - [ ] All Integrations tests are passing with the new commits. - [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.) Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
