vorburger commented on a change in pull request #723: FINERACT-808 FIXES: Some
Action names do not filter audit trails
URL: https://github.com/apache/fineract/pull/723#discussion_r389373158
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/commands/service/AuditReadPlatformServiceImpl.java
##########
@@ -213,7 +213,8 @@ public AuditData mapRow(final ResultSet rs,
@SuppressWarnings("unused") final in
sqlBuilder.append("select SQL_CALC_FOUND_ROWS ");
sqlBuilder.append(rm.schema(includeJson, hierarchy));
sqlBuilder.append(' ').append(updatedExtraCriteria);
- this.columnValidator.validateSqlInjection(sqlBuilder.toString(),
extraCriteria);
+ //Do not validate this is inside a where query
+ //this.columnValidator.validateSqlInjection(sqlBuilder.toString(),
extraCriteria);
Review comment:
just remove this, instead of commenting it out, it's clearer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
