thesmallstar opened a new pull request #733: Removed Console output and added checkstyle module URL: https://github.com/apache/fineract/pull/733 ## Description There were many TODOs, to get started and learn the correct method I thought this would be the easiest one :P The build is passing but I would require following confirmations: 1. Is this the correct approach, should I continue the same way for other TODOs. 2. Since we are removing the console outputs, was it expected to log it? 3. In Listener.java the build failed if the method msg.getText() is not invoked, current implementation seems like a temporary fix, what is the correct way? 4. Removed Console outputs and replaced them with a new line(blank line) any suggestions on this? ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API. - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed. - [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes. - [ ] Integration tests have been created/updated for verifying the changes made. - [ ] All Integrations tests are passing with the new commits. - [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.) Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
