vorburger commented on issue #733: Removed Console output and added checkstyle 
module
URL: https://github.com/apache/fineract/pull/733#issuecomment-599232398
 
 
   > @vorburger I have replaced System.out with LOG statements, but Spotbug is 
bothered with log performance and suggesting some changes, 
   
   Yeah, that's due to the JUST introduced #716, see 
[FINERACT-696](https://issues.apache.org/jira/browse/FINERACT-696) for 
background.
   
    > Is there a way to solve this rather than going individually through all 
200-250 lines?
   
   I pulled this locally and noticed there are 270 violations... too many to 
manually fix up? :smile: Do a bunch every day, instead of all together?
   
   Alternatives I can think of could be to configure Checkstyle to not run this 
particular check on src/test and only src/main, but I think that will be a PITA 
to configure (you would need separate configuration files, and somehow tell the 
Gradle plugin to run different configs for different dirs; I'm not sure that's 
possible), and also confusing for future developers, so I wouldn't do that and 
keep it simple.
   
   In terms of best use of time, what I would probably do if I were you is 
maybe pause this one, and first move on to gradually activating other 
Checkstyle checks, and then come back to this one later / at the end.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to