ptuomola commented on pull request #914:
URL: https://github.com/apache/fineract/pull/914#issuecomment-631851215


   > This looks good to me.
   > In https://issues.apache.org/jira/browse/FINERACT-723 , Seems there are 
other cases like this in other parts of the code base? Do we want to look at 
that later? in a separate issue?
   
   You're right: based on the JIRA, there are probably other scenarios that 
also lead to failures. However these are the only test that fail on my machine 
every day if I run the integration tests in the evening - so I had a personal 
interest in fixing them. My suggestion would be to incorporate this PR if it 
looks OK to you, but we can still keep the JIRA open for other fixes of the 
same nature. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to