ptuomola commented on pull request #914:
URL: https://github.com/apache/fineract/pull/914#issuecomment-631853470


   > See #627 do we need to remove the hard coded Timezone we are setting in 
Travis now with this PR? @vorburger ..Maybe?
   
   The Utils class used by RestAssured also has the tenant timezone hardcoded:
   
   in org.apache.fineract.integrationtests.common.Utils:
       public static final String TENANT_TIME_ZONE = "Asia/Kolkata";
   
   A better solution would of course be to change the Utils class to look this 
up from the database.
   
   After my PR, the current IT scope seems to work as everything is hardcoded 
to point to the same timezone (Asia/Kolkata). To make it work with any timezone 
for tenant/database/application server without any hardcoding, then we will 
need to review/update all code and queries using either application server date 
and database date.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to