thesmallstar commented on pull request #943:
URL: https://github.com/apache/fineract/pull/943#issuecomment-635788551


   @vorburger Do you think it is a good idea to let spotless handle our 
indentation?
   Every one of them including google java format seems to have some variation. 
   
   Take this case for example->
   I tried adding the same indentation as suggested by google checks and ran 
google java format, but the checks still won't pass, there are some ambiguities 
present.
   
   So to let spotless handle out indentation and let checkstyles not interfere 
with it, is a good idea? 
   In fact every such checkstyle which is better if automated like spaces, can 
we let spotless take care?
   Since with one command we would then fix the error, and we cannot have them 
at both places since they won't completely agree on "all" the places(I wonder 
why).
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to