thesmallstar commented on pull request #943: URL: https://github.com/apache/fineract/pull/943#issuecomment-636907089
Yes, I will update this. From what I have understood until now, Spotless and Checkstyles have different approaches. Spotless(Based on the configuration) is more about code formatting and checkstyle is a little bit more intelligent than just code formatting(Not a very good explanation). Keeping both seems a good idea, there are a few checks like naming conventions which cannot be handled by spotless whereas some like indentation/whitespace it would be a really good idea to let spotless take "more" care of it since adding those spaces myself after writing some code would be really troublesome, having said that for a few checks like "space" where spotless and checkstyle agree on everything(either both pass or both fail) we can add a note in check style error message to use spotless to fix this(makes sense?) and keep them both place. Only for a few checks, where they won't agree but it would be a really nice idea to have it automated(like indentation), we can let only spotless handle it. This is what I think would be a good approach if it sounds good to you, should I proceed and add it to readme? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
