vorburger commented on a change in pull request #1049:
URL: https://github.com/apache/fineract/pull/1049#discussion_r439720823
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/scheduledjobs/service/ScheduledJobRunnerServiceImpl.java
##########
@@ -307,7 +307,7 @@ public void updateMaturityDetailsOfDepositAccounts() {
LOG.error("Update maturity details failed for account: {}
with message {}", depositAccount.accountNo(), error.getDeveloperMessage());
}
} catch (final Exception ex) {
- // need to handle this scenario
+ LOG.error("Update maturity details failed for account: {} with
message: {}", depositAccount.accountNo(), ex.getMessage());
Review comment:
as above
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/scheduledjobs/service/ScheduledJobRunnerServiceImpl.java
##########
@@ -229,7 +229,7 @@ public void applyAnnualFeeForSavings() {
LOG.error("Apply annual fee failed for account: {} with
message {}", savingsAccountReference.getAccountNo(), error);
}
} catch (final Exception ex) {
- // need to handle this scenario
+ LOG.error("Apply annual fee failed for account: {} with
message: {}", savingsAccountReference.getAccountNo(), ex.getMessage());
}
Review comment:
LOG.error(..., e) instead of e.getMessage() will log full cause. Or was
this intentional?
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java
##########
@@ -2928,6 +2928,7 @@ public void loadLazyCollections() {
transactions.size();
charges.size();
savingsOfficerHistory.size();
+ if(group != null) { group.getOffice(); }
Review comment:
Is this left over, or for the lazy loading? I fear future automated code
clean up may try to remove this as NOOP... maybe put an inline comment to
explain it forces lazy loading, if that's what it is? Or even fake store it in
a variable used in a useless expression to prevent NOOP clean up? Or remove if
this is just a left over and not actually required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
