ptuomola commented on a change in pull request #1049:
URL: https://github.com/apache/fineract/pull/1049#discussion_r439763954



##########
File path: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java
##########
@@ -2928,6 +2928,7 @@ public void loadLazyCollections() {
         transactions.size();
         charges.size();
         savingsOfficerHistory.size();
+        if(group != null) { group.getOffice(); }

Review comment:
       This is for lazy loading. And yes, I agree it makes sense to make this 
explicit with comment and variable assignment (even though hopefully people 
will work out what's going on from the function name as well). Will update the 
PR. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to