ptuomola commented on a change in pull request #1022:
URL: https://github.com/apache/fineract/pull/1022#discussion_r439856062
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/adhocquery/service/AdHocScheduledJobRunnerServiceImpl.java
##########
@@ -88,10 +88,8 @@ public void generateClientSchedule() {
next = start.plusDays((int) (long)
adhoc.getReportRunEvery());
run = Days.daysBetween(start, end).getDays()
>= adhoc.getReportRunEvery();
break;
- default:
- throw new IllegalStateException();
}
-
+ throw new IllegalStateException();
Review comment:
Isn't this ErrorProne check specifically highlighting switch statements
where the default case is never used, because we are already handling all the
cases specifically? Given that, wouldn't the right solution just be to remove
the default including the throw, and not add anything?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
