percyashu commented on a change in pull request #1022:
URL: https://github.com/apache/fineract/pull/1022#discussion_r440371120
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/adhocquery/service/AdHocScheduledJobRunnerServiceImpl.java
##########
@@ -88,10 +88,8 @@ public void generateClientSchedule() {
next = start.plusDays((int) (long)
adhoc.getReportRunEvery());
run = Days.daysBetween(start, end).getDays()
>= adhoc.getReportRunEvery();
break;
- default:
- throw new IllegalStateException();
}
-
+ throw new IllegalStateException();
Review comment:
@ptuomola I thought so to but it requires a return.
@vorburger I thought if the case is not found, switch default is used with
exception thrown and if case is not found and no default then switch is not
executed then exception is thrown. That's why I did it like this. Just undid
what I did and added a suppressedwarning
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
