ptuomola commented on a change in pull request #1296:
URL: https://github.com/apache/fineract/pull/1296#discussion_r479594561
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
##########
@@ -431,7 +431,7 @@ public LoanTransactionData
retrieveLoanTransactionTemplate(final Long loanId) {
this.context.authenticatedUser();
RepaymentTransactionTemplateMapper mapper = new
RepaymentTransactionTemplateMapper();
- String sql = "select " + mapper.schema() + " where l.id =?";
+ String sql = "select " + mapper.schema();
LoanTransactionData loanTransactionData =
this.jdbcTemplate.queryForObject(sql, mapper,
LoanTransactionType.REPAYMENT.getValue(),
Review comment:
If we are removing one parameter from the query, should we not also pass
one less parameter when we execute the query?
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
##########
@@ -2176,35 +2176,36 @@ public CurrencyData mapRow(ResultSet rs,
@SuppressWarnings("unused") int rowNum)
public String schema() {
StringBuilder sqlBuilder = new StringBuilder();
-
sqlBuilder.append("if(max(tr.transaction_date)>ls.dueDate,max(tr.transaction_date),ls.dueDate)
as transactionDate,");
+
sqlBuilder.append("if(max(tr.transaction_date)>ls.dueDate,max(tr.transaction_date),ls.dueDate)
as transactionDate, ");
sqlBuilder.append(
- "ls.principal_amount -
IFNULL(ls.principal_writtenoff_derived,0) -
IFNULL(ls.principal_completed_derived,0) as principalDue,");
+ "ls.principal_amount -
IFNULL(ls.principal_writtenoff_derived,0) -
IFNULL(ls.principal_completed_derived,0) as principalDue, ");
sqlBuilder.append(
- "ls.interest_amount -
IFNULL(ls.interest_completed_derived,0) - IFNULL(ls.interest_waived_derived,0)
- IFNULL(ls.interest_writtenoff_derived,0) as interestDue,");
+ "ls.interest_amount -
IFNULL(ls.interest_completed_derived,0) - IFNULL(ls.interest_waived_derived,0)
- IFNULL(ls.interest_writtenoff_derived,0) as interestDue, ");
sqlBuilder.append(
- "ls.fee_charges_amount -
IFNULL(ls.fee_charges_completed_derived,0) -
IFNULL(ls.fee_charges_writtenoff_derived,0) -
IFNULL(ls.fee_charges_waived_derived,0) as feeDue,");
+ "ls.fee_charges_amount -
IFNULL(ls.fee_charges_completed_derived,0) -
IFNULL(ls.fee_charges_writtenoff_derived,0) -
IFNULL(ls.fee_charges_waived_derived,0) as feeDue, ");
sqlBuilder.append(
- "ls.penalty_charges_amount -
IFNULL(ls.penalty_charges_completed_derived,0) -
IFNULL(ls.penalty_charges_writtenoff_derived,0) -
IFNULL(ls.penalty_charges_waived_derived,0) as penaltyDue,");
+ "ls.penalty_charges_amount -
IFNULL(ls.penalty_charges_completed_derived,0) -
IFNULL(ls.penalty_charges_writtenoff_derived,0) -
IFNULL(ls.penalty_charges_waived_derived,0) as penaltyDue, ");
sqlBuilder.append(
- " l.currency_code as currencyCode, l.currency_digits as
currencyDigits, l.currency_multiplesof as inMultiplesOf, rc.`name` as
currencyName, ");
- sqlBuilder.append(" rc.display_symbol as currencyDisplaySymbol,
rc.internationalized_name_code as currencyNameCode ");
- sqlBuilder.append(" FROM m_loan l");
Review comment:
Is there a reason for removing all these spaces from beginning of the
strings? The reason for them, as far as I can see, is avoiding a situation
where someone adds before a string that doesn't have a space at the end, and
causes the next string to therefore generate broken SQL. I don't think they are
harmful and can save us from some accidental illegal SQL...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
