francisguchie commented on a change in pull request #1296:
URL: https://github.com/apache/fineract/pull/1296#discussion_r481082652
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
##########
@@ -431,7 +431,7 @@ public LoanTransactionData
retrieveLoanTransactionTemplate(final Long loanId) {
this.context.authenticatedUser();
RepaymentTransactionTemplateMapper mapper = new
RepaymentTransactionTemplateMapper();
- String sql = "select " + mapper.schema() + " where l.id =?";
+ String sql = "select " + mapper.schema();
LoanTransactionData loanTransactionData =
this.jdbcTemplate.queryForObject(sql, mapper,
LoanTransactionType.REPAYMENT.getValue(),
Review comment:
I did not remove the parameter i only put it in its rightful place
sqlBuilder.append(" GROUP BY ls.duedate");
sqlBuilder.append("WHERE l.id = ? ");
just before the groub by object
look at line 2200
But still the sql runs even without this paramater is it is already called
in other places like line 2198, line 2200 is just a "fail safe" parameter just
in case there could be more than one result generated by the SQL script ( you
never know)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
