vidakovic commented on a change in pull request #1402:
URL: https://github.com/apache/fineract/pull/1402#discussion_r504606799
##########
File path: fineract-client/src/main/templates/java/retrofit2/ApiClient.mustache
##########
@@ -0,0 +1,468 @@
+{{>licenseInfo}}
+package {{invokerPackage}};
Review comment:
We could leave them out; the templates are already available as a
dependency... but: I thought we want at least the license info included and
this is the only way to do it. And in the current upstream client generation
there are also a handful of templates tweaking things.
For me both approaches are OK; if we just use the dependencies then one
thing less to maintain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
