ptuomola commented on a change in pull request #1402:
URL: https://github.com/apache/fineract/pull/1402#discussion_r505151736
##########
File path: fineract-provider/build.gradle
##########
@@ -302,140 +125,6 @@ configurations {
runtime
}
-tasks.withType(JavaCompile) {
- options.compilerArgs += [
- "-Xlint:unchecked",
- "-Xlint:cast",
- "-Xlint:auxiliaryclass",
- "-Xlint:deprecation",
- "-Xlint:dep-ann",
- "-Xlint:divzero",
- "-Xlint:empty",
- "-Xlint:exports",
- "-Xlint:fallthrough",
- "-Xlint:finally",
- "-Xlint:module",
- "-Xlint:opens",
- "-Xlint:options",
- "-Xlint:overloads",
- "-Xlint:overrides",
- "-Xlint:path",
- "-Xlint:processing",
- "-Xlint:removal",
- "-Xlint:requires-automatic",
- "-Xlint:requires-transitive-automatic",
- "-Xlint:try",
- "-Xlint:varargs",
- "-Xlint:preview",
- "-Xlint:static",
- "-Werror"
- ]
- // TODO FINERACT-959 (gradually) enable -Xlint:all (see "javac -help -X")
-
- options.deprecation = true
- options.errorprone {
- disableWarningsInGeneratedCode = true
- //Todo Remove necessary checks from this list
- disable(
- "UnusedVariable",
Review comment:
As part of this refactoring, we seem to have lost this ErrorProne
configuration. At least I now get 20 pages of errorprone warnings about all
these things that used to be disabled...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
