vorburger commented on a change in pull request #1402:
URL: https://github.com/apache/fineract/pull/1402#discussion_r506941285



##########
File path: config/fineractdev-cleanup.xml
##########
@@ -1,4 +1,24 @@
 <?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!--

Review comment:
       Not sure why this is suddenly needed here, and what it has to do with 
FINERACT-1189, but doesn't really hurt much either, not a reason to request 
removing it. I do expect that likely will be a small PITA for anyone ever 
making changes to this file again - because it's exported from Eclipse, not 
manually edited, and when Eclipse rewrites it, it will most likely loose this 
ASL header again, so whoever makes such changes will have to manually put it 
back (if we're enforcing this now, else we'll just loose it again sooner or 
later).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to