vorburger commented on a change in pull request #1402:
URL: https://github.com/apache/fineract/pull/1402#discussion_r506938365



##########
File path: .travis.yml
##########
@@ -72,6 +72,6 @@ script:
 # using "&&" instead of several "-" means that integrationTest does not run if 
test fails,
 # and Docker test does not run if integration test fails, which makes PR 
failure easier to understand.
 # @see 
https://docs.travis-ci.com/user/job-lifecycle/#customizing-the-build-phase
-  - ./gradlew --console=plain -PautomatedBuild=true licenseMain licenseTest 
licenseIntegrationTest check  &&  ./gradlew --console=plain 
-PautomatedBuild=true integrationTest --fail-fast  &&  sudo service mysql stop  
&&  docker-compose build  &&  docker-compose up -d  &&  sleep 60s  && curl -f 
-k --retry 5 --retry-connrefused --connect-timeout 30 --retry-delay 30 
https://localhost:8443/fineract-provider/actuator/health  &&  (( $(curl -f -k 
--retry 5 --retry-connrefused --connect-timeout 30 --retry-delay 30 
https://localhost:8443/fineract-provider/actuator/info | wc --chars) > 100 )) 
&& ./gradlew generateSwaggerCode && cd 
fineract-provider/build/swagger-code-fineract && mvn test
+  - ./gradlew --console=plain -PautomatedBuild=true licenseMain licenseTest 
licenseIntegrationTest check  &&  ./gradlew --console=plain 
-PautomatedBuild=true integrationTest --fail-fast  &&  sudo service mysql stop  
&&  docker-compose build  &&  docker-compose up -d  &&  sleep 60s  && curl -f 
-k --retry 5 --retry-connrefused --connect-timeout 30 --retry-delay 30 
https://localhost:8443/fineract-provider/actuator/health  &&  (( $(curl -f -k 
--retry 5 --retry-connrefused --connect-timeout 30 --retry-delay 30 
https://localhost:8443/fineract-provider/actuator/info | wc --chars) > 100 ))

Review comment:
       @vidakovic wait, what does this Q have to do with the (now removed) 
license headers? I may be missing something. What I was asking about here is 
why we're removing `./gradlew generateSwaggerCode` from Travis.. I've just 
pulled this PR and tried building it locally, and noticed that Gradle task 
doesn't seem to exist anymore now, so.. do we not need to run this on Travis 
anymore now, because... Swagger code generation now runs as part of the multi 
module build in `fineract-client`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to