EGOR-IND commented on a change in pull request #186:
URL: https://github.com/apache/fineract-cn-mobile/pull/186#discussion_r618128620



##########
File path: app/src/main/res/values/strings.xml
##########
@@ -412,6 +412,12 @@
     <string name="please_wait">Please wait &#8230;</string>
     <string name="logging_in">Logging in…</string>
 
+    <!--Edit Check Messages-->
+    <string name="customer_edit_check_msg">Information not edited for the 
customer %1$s</string>
+    <string name="group_edit_check_msg">Information not edited for the group 
%1$s</string>
+    <string name="payroll_edit_check_msg">Information not edited for the 
payroll with customer identifier %1$s</string>
+    <string name="identification_edit_check_msg">Information not edited for 
the identification type %1$s</string>
+

Review comment:
       See I think toasts are good, I don't see any harm in that, it's just a 
simple indicatiin that they haven't change anything, I can add a dialog if you 
find snackbar inconvenient, the dialog can have an exit and cancel button, user 
can exit if they don't want any changes or they can simply press cancel and get 
back to the edit section. What do you think? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to