PatelVatsalB21 commented on a change in pull request #186:
URL: https://github.com/apache/fineract-cn-mobile/pull/186#discussion_r618228950
##########
File path: app/src/main/res/values/strings.xml
##########
@@ -412,6 +412,12 @@
<string name="please_wait">Please wait …</string>
<string name="logging_in">Logging in…</string>
+ <!--Edit Check Messages-->
+ <string name="customer_edit_check_msg">Information not edited for the
customer %1$s</string>
+ <string name="group_edit_check_msg">Information not edited for the group
%1$s</string>
+ <string name="payroll_edit_check_msg">Information not edited for the
payroll with customer identifier %1$s</string>
+ <string name="identification_edit_check_msg">Information not edited for
the identification type %1$s</string>
+
Review comment:
I dont find toast bad but as you suggested it is better to confirm and
save change if user edited or else it should show something like "You didn't
change any data. Are you sure you want to exit?". It be probably better that
this toast.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
