josemakara2 commented on pull request #1693: URL: https://github.com/apache/fineract/pull/1693#issuecomment-841765803
> To move forward with this, I've made the proposed changes in a separate PR: #1734. Can you check if this fixes the issue for you, and if yes I can then merge it? :thumbsup: +1: for program to interface, not implementation. Tested that in my PR and yes #1734 can be merged after the `format fix` and then we close this PR. I prefer merge squash to re basing. Many thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
