ptuomola commented on pull request #1693: URL: https://github.com/apache/fineract/pull/1693#issuecomment-841751538
Ok - had a look at this and fully agree with the fix. However can I suggest we keep the logic so that the selection of report type is in getReportType() and not split between two different places. Also we should keep the return value from findReportingProcessService() as the generic type, not specific to DatatableReportingProcessService, as otherwise this may break the possible plug-ins for this (e.g. Pentaho reporting plugin). To move forward with this, I've made the proposed changes in a separate PR: https://github.com/apache/fineract/pull/1734. Can you check if this fixes the issue for you, and if yes I can then merge it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
