ptuomola commented on pull request #1894: URL: https://github.com/apache/fineract/pull/1894#issuecomment-947597093
All the PRs were failing with the same error. As soon as I reverted this, they started passing. To me it seems clear that this PR caused them to fail. And yes, I do think it should be the responsibility of the person submitting the PR to ensure that the tests pass. That’s what our PR guidelines say as well, and that’s certainly the standard that I’ve always followed with my own PRs. On Wed, 20 Oct 2021 at 7:49 PM, Avik Ganguly ***@***.***> wrote: > @avikganguly01 <https://github.com/avikganguly01> @francisguchie > <https://github.com/francisguchie> @ankita10r > <https://github.com/ankita10r> @IOhacker <https://github.com/IOhacker> > > This has now broken the build, and all the other builds are failing. We > should *never* merge failing builds please. I will try to revert this > change - please can you fix the failing tests before merging again. > > @IOhacker <https://github.com/IOhacker> : There are 10+ tests like > testSkippingRepaymentOnFirstDayOfMonth() which fails randomly and has > nothing to do with this PR. > > @ptuomola <https://github.com/ptuomola> : Can you be more specific with > regards to which integration test failed because of this PR? Do not revert > this change unless proven otherwise. The author of this PR is not > responsible for fixing all the integration tests which fail due to no fault > of hers. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/fineract/pull/1894#issuecomment-947587901>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AASJVCRDMVAGVHTM4T7YCPTUH2UDRANCNFSM5GG2FFOQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
