ptuomola commented on pull request #1894: URL: https://github.com/apache/fineract/pull/1894#issuecomment-949110683
Hi @avikganguly01 (cc @awasum @fynmanoj) Unfortunately I disagree with your description of the current state of the Fineract branch. Looking at the pull request history, I've merged around 350 PRs over the two years or so. For each of these, I've ensured all the tests pass before merging. So, in my view, this is not an unrealistic expectation. In fact, this is the only way we can make sure things improve rather than degrade. I agree there are still some flaky tests. But we've made a huge amount of progress on this over the last year: I've fixed at least 30 such tests myself. There are still a couple of known issues with: a) performance of Travis (sometimes the build takes too long due to load on the Travis infra, and some tests time out) b) month end (some tests fail on last / first day of months, due to the fact that different months have different number of days and this confuses the checking routines for interest calculation) I agree we should fix these. But these handful of issues should not be an excuse for allowing code to be merged that breaks additional tests, without even investigating why the tests are failing. That will take us even further away from our goal of having reliable tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
