ptuomola commented on pull request #1955: URL: https://github.com/apache/fineract/pull/1955#issuecomment-961648176
Yes spot on - that’s actually the problem I have not yet managed to resolve with this migration to GitHub Actions. That token is actually already encrypted. Travis has a feature to decrypt it before using, hence it’s safe to add it there. But Github does not have such feature, hence Sonarqube as git action is currently failing as it can’t use the encrypted token. The three options that I can see to implement the same on GitHub are: 1. Use Github secrets. But my understanding is that that’s not allowed for Apache repos 2. Use Sonarqubes GitHub app. Again, not allowed as far as I know 3. Put the token as plaintext. Insecure, so really not a good plan. So I think for now I’ll focus on trying to get the build to run in GitHub Actions. We can leave Sonarqube on Travis for now, until someone comes up with a good idea on how to solve this. On Fri, 5 Nov 2021 at 1:46 PM, Aleksandar Vidakovic < ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In .github/workflows/sonarqube.yml > <https://github.com/apache/fineract/pull/1955#discussion_r743402519>: > > > @@ -0,0 +1,32 @@ > +name: Fineract Sonarqube > +on: [push] > + > +jobs: > + build: > + runs-on: ubuntu-20.04 > + env: > + TZ: Asia/Kolkata > + SONAR_ORGANIZATION: apache > + SONAR_HOST_URL: https://sonarcloud.io > + SONAR_TOKEN: "Q2E9ijK+9+R6nkb9o2FQrKUiAozp0325mlGfM25rGV3mCRPyWR/lU8o48r2eaBEX8SEvMvXIO3XXD9SPyUX2+svLz0MOMdfZfNveg6jmcHNRjkzzBK0bMIIGbEH/YqJ+psl4nDmlDd6IK4685/1JSRUJLqeKKK2ulixm6PXcmwZWeKD6TjyXsW50zz3yYIOuROHzys/M6H05h1dZD3j6ztnRsjbr7SmqFEVWSRgEd/aAs+HZB9Fv1xN66csRoQUQKgzoBO9egAQcel65Av0Bf+pOQuzVDVyXNohZEYia02MCGlC6OFvtL7xIXGf/vo02RdnlN4Jnma6P37TaNrmpk2e+EGJaZHmL9cb98+Zc39uPb7qEZkMfDdKrW6QVRtScSuCJzpY58WRgTS0jLCxsDBAMfsrIvWbHntFZL9q5aEkFgecj0pg9u6WHxgA8cuPUY5QzHQo9fEUxNJHGJHQ2FkafLniqJp7DVbsyQHmEggaTrGGrketeYvCbSR1oOnBgImUwzjIV9/zOdd10Wzi8x9HsmzrGBPSBaO4fBxjC1LZwdyue2a2+oKvBqpAGcLpGaCRfHTh2yPXhZW4bw11rOmQxgtOQVBXhveciWAUQuVXIak+RZnu/zRvnul9sZ6bb1hEUPkpUypk+FDeLm8T7y2A++u/jBam2vLc0iff5xtA=" > > @ptuomola <https://github.com/ptuomola> should we move this to Github's > settings -> security -> secrets? I tried to access that page on Github... > but have not enough privileges... probably that's why you put it here... > just as a note. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/fineract/pull/1955#pullrequestreview-798513583>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AASJVCVEQAODNBMZ2GESDD3UKNVTDANCNFSM5HLTWCBA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
