awasum commented on a change in pull request #1955:
URL: https://github.com/apache/fineract/pull/1955#discussion_r743186530
##########
File path: .github/workflows/build-docker.yml
##########
@@ -0,0 +1,20 @@
+name: Fineract Docker build
+
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
Review comment:
Lets use Latest LTS version say Ubuntu 20.04 here..Minor..but makes
sense. See:
https://cloudmaniac.net/docker-container-never-use-latest-cicd-pipeline/
##########
File path: .github/workflows/build.yml
##########
@@ -0,0 +1,38 @@
+name: Fineract Gradle build
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ env:
+ TZ: Asia/Kolkata
Review comment:
@ptuomola already answered this here and it makes sense. Thanks...so
resolving this. see:
https://github.com/apache/fineract/pull/1955#issuecomment-961172334
##########
File path: .github/workflows/sonarqube.yml
##########
@@ -0,0 +1,32 @@
+name: Fineract Sonarqube
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
Review comment:
Just minor: See above:
https://github.com/apache/fineract/pull/1955/files#r743186530
##########
File path: .github/workflows/build-docker.yml
##########
@@ -0,0 +1,20 @@
+name: Fineract Docker build
+
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
Review comment:
Lets use Latest LTS version say Ubuntu 20.04 here..Minor..but makes
sense. See:
https://cloudmaniac.net/docker-container-never-use-latest-cicd-pipeline/
##########
File path: .github/workflows/build.yml
##########
@@ -0,0 +1,38 @@
+name: Fineract Gradle build
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+ env:
+ TZ: Asia/Kolkata
Review comment:
@ptuomola already answered this here and it makes sense. Thanks...so
resolving this. see:
https://github.com/apache/fineract/pull/1955#issuecomment-961172334
##########
File path: .github/workflows/sonarqube.yml
##########
@@ -0,0 +1,32 @@
+name: Fineract Sonarqube
+on: [push]
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
Review comment:
Just minor: See above:
https://github.com/apache/fineract/pull/1955/files#r743186530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
