vorburger commented on a change in pull request #1994:
URL: https://github.com/apache/fineract/pull/1994#discussion_r766831540
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/service/ExternalServicesPropertiesReadPlatformServiceImpl.java
##########
@@ -83,7 +83,7 @@ public SMTPCredentialsData extractData(final ResultSet rs)
throws SQLException,
if
(ExternalServicesConstants.SMTP_USERNAME.equalsIgnoreCase(name)) {
username = value;
- } else if
(ExternalServicesConstants.SMTP_PORT.equalsIgnoreCase(port)) {
+ } else if
(ExternalServicesConstants.SMTP_PORT.equalsIgnoreCase(name)) {
Review comment:
sorry yeah no this is obviously right (it makes more sense looking at
the full file then the diff here), nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
