ptuomola commented on a change in pull request #1994:
URL: https://github.com/apache/fineract/pull/1994#discussion_r766943898



##########
File path: 
twofactor-tests/src/test/java/org/apache/fineract/twofactortests/common/Utils.java
##########
@@ -0,0 +1,267 @@
+/**

Review comment:
       I'm only using two methods from that so can inline them into the other 
class and delete this. 
   
   I agree that it would be good to move away from restassured etc.  But I 
haven't spent much time with fineract-client yet, and just wanted to quickly 
come up with something that stops us from accidentally breaking non-basicauth 
profiles - as we had recently done without noticing. Very happy if someone 
wants to do this better ie with fineract-client etc...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to