galovics commented on a change in pull request #1984:
URL: https://github.com/apache/fineract/pull/1984#discussion_r818602019
##########
File path:
fineract-provider/src/main/resources/db/changelog/tenant/parts/0002_initial_data.xml
##########
@@ -2204,7 +2204,7 @@
<column name="code" value="INR"/>
<column name="decimal_places" valueNumeric="2"/>
<column name="currency_multiplesof"/>
- <column name="display_symbol" value="₹"/>
+ <column name="display_symbol"/>
Review comment:
Same as above.
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/command/ClientIdentifierCommand.java
##########
@@ -50,18 +57,29 @@ public String getDocumentKey() {
return this.documentKey;
}
+ public String getdocumentIssueCountry() {
+ return this.documentIssueCountry;
+ }
+
public String getDescription() {
return this.description;
}
- public void validateForCreate() {
+ public void validateForCreate(final CodeValue documentType, final
JsonCommand command) {
final List<ApiParameterError> dataValidationErrors = new ArrayList<>();
final DataValidatorBuilder baseDataValidator = new
DataValidatorBuilder(dataValidationErrors).resource("clientIdentifier");
baseDataValidator.reset().parameter("documentTypeId").value(this.documentTypeId).notNull().integerGreaterThanZero();
baseDataValidator.reset().parameter("documentKey").value(this.documentKey).notBlank();
+ if
(documentType.label().equals(ClientApiConstants.clientIdentifierPassportParamName.toString()))
{
Review comment:
Is there a need to actually call the toString() on that constant? It
would also even better if we could switch the order of the equality check to be
null-safe.
Thoughts?
##########
File path:
fineract-provider/src/main/resources/db/changelog/tenant/parts/0002_initial_data.xml
##########
@@ -2672,7 +2672,7 @@
<column name="code" value="PYG"/>
<column name="decimal_places" valueNumeric="0"/>
<column name="currency_multiplesof"/>
- <column name="display_symbol" value="₲"/>
+ <column name="display_symbol"/>
Review comment:
Same as above.
##########
File path:
fineract-provider/src/main/resources/db/changelog/tenant/parts/0002_initial_data.xml
##########
@@ -1916,7 +1916,7 @@
<column name="code" value="CRC"/>
<column name="decimal_places" valueNumeric="2"/>
<column name="currency_multiplesof"/>
- <column name="display_symbol" value="₡"/>
+ <column name="display_symbol"/>
Review comment:
Let's not change anything in the existing changelog files. If you would
like to remove the display_symbol for these currencies, let's add a new
changelog file with the changes needed.
Btw, any reason you decided to remove these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
