rrpawar96 commented on a change in pull request #1984:
URL: https://github.com/apache/fineract/pull/1984#discussion_r818969696
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/command/ClientIdentifierCommand.java
##########
@@ -50,18 +57,29 @@ public String getDocumentKey() {
return this.documentKey;
}
+ public String getdocumentIssueCountry() {
+ return this.documentIssueCountry;
+ }
+
public String getDescription() {
return this.description;
}
- public void validateForCreate() {
+ public void validateForCreate(final CodeValue documentType, final
JsonCommand command) {
final List<ApiParameterError> dataValidationErrors = new ArrayList<>();
final DataValidatorBuilder baseDataValidator = new
DataValidatorBuilder(dataValidationErrors).resource("clientIdentifier");
baseDataValidator.reset().parameter("documentTypeId").value(this.documentTypeId).notNull().integerGreaterThanZero();
baseDataValidator.reset().parameter("documentKey").value(this.documentKey).notBlank();
+ if
(documentType.label().equals(ClientApiConstants.clientIdentifierPassportParamName.toString()))
{
Review comment:
Addressed,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
