galovics edited a comment on pull request #1984: URL: https://github.com/apache/fineract/pull/1984#issuecomment-1062908825
Hi @rrpawar96 , yeah, I can see why. You're going to read the properties file for each SQL query, that's definitely not the way. What we should do instead: * Upon application startup, load the properties file and keep the mapping in memory * Upon the need to translate country codes to country names, use the mapping in the memory to resolve the country name Also, please make sure we're following the ResourceBundle naming convention, i.e. let's call the file `countries_en.properties` instead of `countries.properties`. Note: for the country translation, you could introduce a brand new service class to deal with the preloading and doing the actual translation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
