vidakovic commented on code in PR #2455:
URL: https://github.com/apache/fineract/pull/2455#discussion_r933401542
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/data/GLAccountData.java:
##########
@@ -132,14 +135,6 @@ private GLAccountData(String name, Long parentId, String
glCode, Boolean manualE
this.allowedExpensesTagOptions = null;
Review Comment:
These explicit null assignments make no sense... just to say: that's empty
code and no reason why not to replace these constructors... also having
multiple constructors is an anti-pattern, so let's try again with the Lombok
annotation and get rid of this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
