vidakovic commented on code in PR #2455:
URL: https://github.com/apache/fineract/pull/2455#discussion_r934006399
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/financialactivityaccount/service/FinancialActivityAccountReadPlatformServiceImpl.java:
##########
@@ -101,8 +101,12 @@ public FinancialActivityAccountData mapRow(final ResultSet
rs, @SuppressWarnings
final Integer financialActivityId = JdbcSupport.getInteger(rs,
"financialActivityId");
final String glAccountName = rs.getString("glAccountName");
final String glCode = rs.getString("glCode");
-
- final GLAccountData glAccountData = new GLAccountData(glAccountId,
glAccountName, glCode);
+ //@formatter:off
Review Comment:
I'm not sure if we should keep these formatting comments in place... I used
them only in my example PR to make sure these parts are highlighted and
readable. While I still like the formatting here with those comments, I think
we should remove them, because others will copy them to circumvent our general
formatting rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
