josehernandezfintecheandomx commented on code in PR #2566:
URL: https://github.com/apache/fineract/pull/2566#discussion_r962959417
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java:
##########
@@ -167,9 +167,26 @@ public CommandProcessingResult
applyDelinquencyTagToLoan(Long loanId, JsonComman
@Override
public void applyDelinquencyTagToLoan(Long loanId, Long ageDays) {
final Loan loan =
this.loanRepository.findOneWithNotFoundDetection(loanId);
- final DelinquencyBucket delinquencyBucket =
loan.getLoanProduct().getDelinquencyBucket();
- if (delinquencyBucket != null) {
- lookUpDelinquencyRange(loan, delinquencyBucket, ageDays);
+ applyDelinquencyTagToLoan(loan, ageDays);
+ }
+
+ @Override
+ public void applyDelinquencyTagToLoan(final Loan loan, Long ageDays) {
+ if (loan.hasDelinquencyBucket()) {
+ lookUpDelinquencyRange(loan,
loan.getLoanProduct().getDelinquencyBucket(), ageDays);
+ }
+ }
+
+ @Override
+ public void removeDelinquencyTagToLoan(final Loan loan) {
+ setLoanDelinquencyTag(loan, null);
+ }
+
+ @Override
+ public void cleanLoanDelinquencyTags(Loan loan) {
Review Comment:
It was more considering in the UndoDisbursal case mainly, even now that
method is not being called yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
